Skip to content

Set default width/height for toImage to null i.e. rendered size. #5206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set default width/height for toImage to null i.e. rendered size. #5206

wants to merge 1 commit into from

Conversation

nicolaskruchten
Copy link
Contributor

Nicer alternative to #5205

@archmoj archmoj added status: reviewable bug something broken labels Oct 9, 2020
@alexcjohnson
Copy link
Collaborator

LGTM - is there a useful test we can make of this new behavior?

@nicolaskruchten
Copy link
Contributor Author

Doesn't actually work :)

@alexcjohnson alexcjohnson deleted the nicolaskruchten-patch-2 branch October 11, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaskruchten @alexcjohnson @archmoj